-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilities/StaticAnalyzers: Update function dumper to not add virtual at the end of function calls #35001
Utilities/StaticAnalyzers: Update function dumper to not add virtual at the end of function calls #35001
Conversation
…at the end of function call printout. Change category of some checks to deprecated.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35001/24857
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages:
@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35001/24858
|
Pull request #35001 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d54f1/18008/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Utilities/StaticAnalyzers: Update function dumper to not add virtual at the end of function calls.
Change category of some checks to deprecated "Deprecated API"
PR description:
The addition of virtual at the end of the function call printout was causing
function 'cms::CkfTrackCandidateMaker::produce(edm::Event &, const edm::EventSetup &)' calls function 'cms::CkfTrackCandidateMakerBase::produceBase(edm::Event &, const edm::EventSetup &) virtual' function
to not be linked to
function 'cms::CkfTrackCandidateMakerBase::produceBase(edm::Event &, const edm::EventSetup &)' calls function 'edm::eventsetup::EventSetupRecord::get<class edm::ESHandle<class TrackerGeometry>>(class edm::ESHandle<class TrackerGeometry> &) const'
This prevented the call stack from being reported in the ESR::get() report.